This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Simplify POI panel CSS #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
force-pushed
the
poi-panel-css
branch
from
23cab37
to
d42af9c
Compare
bbecquet
force-pushed
the
poi-panel-css
branch
from
d42af9c
to
1ab8b93
Compare
amatissart
previously approved these changes
Aug 14, 2019
| position: relative; | ||
| margin-bottom: 10px; | ||
| overflow: auto; | ||
| display: flex; |
There was a problem hiding this comment.
Without this margin-bottom, the "osm_contribute" div is packed below the buttons (when no other block is present)
Maybe add a margin-top on .osm_contribute ?
There was a problem hiding this comment.
Thanks, I was a bit too quick to remove rules. I re-introduced a margin-bottom, as it's easier to manage only bottom margins when stacking components. It looks better indeed :)
amatissart
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify some markup and CSS in the POI panel, especially start using
display: flexboxinstead offloatto improve some layouts (tested successfully on IE11) and simplify the complicated action buttons.Why
Most layout DOM and CSS are far too complicated and use obsolete layout techniques. Ease future migration to another view framework.